Lolli 14 #14
Merged
Lolli 14 #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a drop in replacement if php-mbstring is not available. Using symfony/polyfill-mbstring we avoid the hard dependency to php-mbstring. composer req symfony/polyfill-mbstring
extractFragments() is only called from within diff(), which tests for empty $delimiters aleady, the if body in extractFragments() can't be reached. Avoids call to non-multibyte safe str_split().
Adds type hints where possible. Main methods like Diff->render() now accept strings and similar. Enables phpstan level 6. This is b/w compat breaking since types are now enforced.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.