Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style(boot): remove workaround warning comment #1915

Merged
merged 1 commit into from
Oct 25, 2018
Merged

style(boot): remove workaround warning comment #1915

merged 1 commit into from
Oct 25, 2018

Conversation

Yaty
Copy link
Contributor

@Yaty Yaty commented Oct 25, 2018

nodejs/node#20278 was solved so Object.entries/values can now be used.

Checklist

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

@Yaty Yaty changed the title refactor(boot): remove 'for in' workaround style(boot): remove workaround warning comment Oct 25, 2018
@raymondfeng raymondfeng merged commit c63e9eb into loopbackio:master Oct 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raymondfeng raymondfeng raymondfeng approved these changes

@bajtos bajtos Awaiting requested review from bajtos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yaty @raymondfeng