Add Entity to Base Event - cake 4.x #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation test, uses mocks for testing elastic locally, some other cleanup
dereuromark
reviewed
Dec 6, 2023
Co-authored-by: Mark Scherer <dereuromark@users.noreply.github.com>
|
@cnizzardini this will need to be rebased now that the cake 5 changes were merged |
|
I can do that, but I'd like it in both since everything I work on is still 4.x. |
|
If I can get the few items I have added in that require cakephp 4.x I will only do future PRs against cakephp 5. |
|
@cnizzardini I have created the branch |
cnizzardini
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the Entity being changed to the Event so listeners can access it.