-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logos Stadt Münster entfernen #1
Open
Smart-City-Muenster
wants to merge
36
commits into
lorenzomorning:main
Choose a base branch
from
Smart-City-Muenster:patch-3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Logos Stadt Münster entfernen #1
Smart-City-Muenster
wants to merge
36
commits into
lorenzomorning:main
from
Smart-City-Muenster:patch-3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for urban-cycling-dashboard-muenster failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hallo Lorenz,
danke für Deine coole Arbeit, die Dashboard-Erweiterung ist richtig super geworden!
Aktuell sieht es allerdings noch so aus, als würde das Dashboard von uns als Smart City / Stadt Münster herausgegeben.
Da das nicht so ist, würde ich Dich bitten, alle städtischen Logos zu entfernen und auch den Hinweistext auf der "Info"-Seite anzupassen.
Mit diesem PR habe hoffentlich schon alle Logos erwischt und auch einen Formulierungsvorschlag für die Info-Seite gemacht.
Ich habe aber natürlich nicht geprüft, ob das Dashboard noch funktioniert, wenn man, wie ich, einfach die Logo-Dateien löscht.
Danke fürs Berücksichtigen!
Viele Grüße
Thomas