Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): update autoOrient type to include undefined #4362

Merged
merged 1 commit into from
Apr 4, 2025

Conversation

styfle
Copy link
Contributor

@styfle styfle commented Apr 4, 2025

This PR fixes the following error:

node_modules/sharp/lib/index.d.ts(1590,15): error TS2430: Interface 'OverlayOptions' incorrectly extends interface 'SharpOptions'.
  Types of property 'autoOrient' are incompatible.
    Type 'boolean | undefined' is not assignable to type 'boolean'.
      Type 'undefined' is not assignable to type 'boolean'.

The bug was introduced in:

This PR fixes the following error:

```
node_modules/.pnpm/sharp@0.34.0/node_modules/sharp/lib/index.d.ts(1590,15): error TS2430: Interface 'OverlayOptions' incorrectly extends interface 'SharpOptions'.
  Types of property 'autoOrient' are incompatible.
    Type 'boolean | undefined' is not assignable to type 'boolean'.
      Type 'undefined' is not assignable to type 'boolean'.
```
@styfle
Copy link
Contributor Author

styfle commented Apr 4, 2025

I discovered this when updating vercel/next.js here:

cc @lovell

@lovell lovell merged commit 3c7dbb8 into lovell:main Apr 4, 2025
22 checks passed
@lovell lovell added this to the v0.34.1 milestone Apr 4, 2025
@lovell
Copy link
Owner

lovell commented Apr 4, 2025

Thank you Steven!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants