Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More digi #46

Merged
merged 55 commits into from
Apr 30, 2024
Merged
Changes from 1 commit
Commits
Show all changes
55 commits
Select commit Hold shift + click to select a range
73e64ba
Initial implementation of new digitization classes.
lucabaldini Apr 11, 2024
cb25732
Continued implementation of sparse readout class
chiaratomaiuolo Apr 11, 2024
921e568
Minor.
lucabaldini Apr 12, 2024
7693351
First complete implementation of the sparse readout.
lucabaldini Apr 12, 2024
aca4816
Started implementing circular readout
chiaratomaiuolo Apr 12, 2024
5cc029d
Merge conflicts fixed
chiaratomaiuolo Apr 12, 2024
b49776a
Minor.
lucabaldini Apr 12, 2024
1cf5489
Started working on the refactoring of the fileio.
lucabaldini Apr 12, 2024
1dc9b44
Fix for trigger id.
lucabaldini Apr 12, 2024
ca99f4b
Initial import.
lucabaldini Apr 12, 2024
2274f01
Old DigiEvent class removed and fixed unit tests
lucabaldini Apr 12, 2024
b0f714c
Old generic classes removed.
lucabaldini Apr 12, 2024
1dd58a8
Initial import.
lucabaldini Apr 12, 2024
06c8030
Old digi module split into digi and readout.
lucabaldini Apr 12, 2024
b3b7fb3
pylinted.
lucabaldini Apr 12, 2024
6d667dd
Started implementing circular readout
chiaratomaiuolo Apr 15, 2024
cd4a77c
Merge branch 'main' into more_digi
lucabaldini Apr 16, 2024
e406e34
Small refactoring.
lucabaldini Apr 16, 2024
37a95db
Minor.
lucabaldini Apr 16, 2024
2379b5b
finished testing conversion from logic coords to 7-adc coords
chiaratomaiuolo Apr 16, 2024
2f0c3a9
Implementing circular readout
chiaratomaiuolo Apr 17, 2024
77b5fe4
Minor.
lucabaldini Apr 19, 2024
28f27be
removed CircularROI class
chiaratomaiuolo Apr 19, 2024
398e746
minor
chiaratomaiuolo Apr 19, 2024
c92f9d4
Implemented DigiEventCircular ascii function
chiaratomaiuolo Apr 20, 2024
688f263
started implementing readout_strategy option for the simulation
chiaratomaiuolo Apr 22, 2024
c5f7013
Minor.
lucabaldini Apr 22, 2024
18de75e
started implementation of different DigiOutputFile(s) and started tes…
chiaratomaiuolo Apr 22, 2024
a63b459
continued implementing I/O for the different modes of readout
chiaratomaiuolo Apr 23, 2024
fff434c
continued implementing I/O for different readout types
chiaratomaiuolo Apr 23, 2024
eaf2793
Continued implementing classes for file I/O
chiaratomaiuolo Apr 23, 2024
7f6d16c
Continued implementing I/O facilities
chiaratomaiuolo Apr 23, 2024
ed9518c
Finished implementing I/O for every radout mode and tested the readin…
chiaratomaiuolo Apr 24, 2024
4c533ff
Minor
chiaratomaiuolo Apr 24, 2024
9359be4
Created DigiInputFileBase class
chiaratomaiuolo Apr 24, 2024
7559e3e
Modified run() function for different modes of readout
chiaratomaiuolo Apr 24, 2024
1ddfe5d
minor
chiaratomaiuolo Apr 24, 2024
13b5921
continued updating header in I/O files for every readout mode
chiaratomaiuolo Apr 24, 2024
8dedfed
minor
chiaratomaiuolo Apr 24, 2024
e0b0f88
minor
chiaratomaiuolo Apr 24, 2024
32b55c4
minor
chiaratomaiuolo Apr 29, 2024
c46036f
/minor/
chiaratomaiuolo Apr 29, 2024
460f241
minor
chiaratomaiuolo Apr 29, 2024
c4ba7ea
minor
chiaratomaiuolo Apr 29, 2024
9e05588
Implemented some plots for evaluating reconstruction
chiaratomaiuolo Apr 29, 2024
2b9eeef
minor
chiaratomaiuolo Apr 29, 2024
c0be1ef
minor
chiaratomaiuolo Apr 29, 2024
255fa85
created file for recon vs MC quantities evaluation
chiaratomaiuolo Apr 29, 2024
f0d4f26
minor
chiaratomaiuolo Apr 29, 2024
2854e39
Minor.
lucabaldini Apr 30, 2024
67e7f94
Merge branch 'more_digi' of github.com:lucabaldini/hexsample into mor…
lucabaldini Apr 30, 2024
a35f823
minor
chiaratomaiuolo Apr 30, 2024
6e21816
hexsample/bin/hxplots.py
chiaratomaiuolo Apr 30, 2024
34827bc
Fixed unit tests.
lucabaldini Apr 30, 2024
18dd12d
Updated release notes.
lucabaldini Apr 30, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
minor
chiaratomaiuolo committed Apr 29, 2024
commit 460f2412dfff7cca6ff333abc87775d937558706
26 changes: 26 additions & 0 deletions hexsample/bin/hxsim.py
Original file line number Diff line number Diff line change
@@ -82,6 +82,32 @@ def hxsim(**kwargs):
output_file = digioutput_class(readout_mode)(output_file_path)
output_file.update_header(**kwargs)
logger.info('Starting the event loop...')
"""
while trigger_id <= kwargs['numevents']:
photon_event = PhotonList(source, sensor, 1)
readout_mode = HexagonalReadoutMode(kwargs['mode'])
# Is there any nicer way to do this? See https://github.com/lucabaldini/hexsample/issues/51
if readout_mode is HexagonalReadoutMode.SPARSE:
readout_args = kwargs['trgthreshold'], kwargs['zsupthreshold'], kwargs['offset']
elif readout_mode is HexagonalReadoutMode.RECTANGULAR:
padding = Padding(*kwargs['padding'])
readout_args = kwargs['trgthreshold'], padding, kwargs['zsupthreshold'], kwargs['offset']
elif readout_mode is HexagonalReadoutMode.CIRCULAR:
readout_args = kwargs['trgthreshold'], kwargs['zsupthreshold'], kwargs['offset']
else:
raise RuntimeError
args = HexagonalLayout(kwargs['layout']), kwargs['numcolumns'], kwargs['numrows'],\
kwargs['pitch'], kwargs['noise'], kwargs['gain']
readout = readout_chip(readout_mode, *args)
logger.info(f'Readout chip: {readout}')
output_file_path = kwargs.get('outfile')
output_file = digioutput_class(readout_mode)(output_file_path)
output_file.update_header(**kwargs)
logger.info('Starting the event loop...')
x, y = mc_event.propagate(sensor.trans_diffusion_sigma)
digi_event = readout.read(mc_event.timestamp, x, y, *readout_args)
output_file.add_row(digi_event, mc_event)
"""
for mc_event in tqdm(photon_list):
x, y = mc_event.propagate(sensor.trans_diffusion_sigma)
digi_event = readout.read(mc_event.timestamp, x, y, *readout_args)
4 changes: 2 additions & 2 deletions hexsample/clustering.py
Original file line number Diff line number Diff line change
@@ -114,7 +114,7 @@ def run(self, event: DigiEventSparse | DigiEventRectangular | DigiEventCircular)
"""
if isinstance(event, DigiEventSparse):
pass
if isinstance(event, DigiEventCircular):
elif isinstance(event, DigiEventCircular):
# If the readout is circular, we want to take all the neirest neighbors.
self.num_neighbors = HexagonalReadoutCircular.NUM_PIXELS - 1 # -1 is bc the central px is already considered
col = [event.column]
@@ -133,7 +133,7 @@ def run(self, event: DigiEventSparse | DigiEventRectangular | DigiEventCircular)
row = np.array(row)
pha = np.array(pha)
# pylint: disable = invalid-name
if isinstance(event, DigiEventRectangular):
elif isinstance(event, DigiEventRectangular):
seed_col, seed_row = event.highest_pixel()
col = [seed_col]
row = [seed_row]