fix: correct on_error_gcode in mainsail.cfg #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
meteyou
approved these changes
Jun 6, 2022
meteyou
pushed a commit
that referenced
this pull request
Jun 6, 2022
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes any reference to
error_messagevariable in theon_gcode_errorblock as this Klipper variable was removed before merging into master.When this block of code runs the print will already have been stopped, so I do believe it will be safe to just call
CANCEL_PRINTwhatever the error was.Related Klipper docs: https://www.klipper3d.org/Config_Reference.html#virtual_sdcard
Related to #116
Signed-off-by: Pedro Lamas pedrolamas@gmail.com