[New Source] Panda Waste, Ireland #3749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcacace
changed the title
gcacace
force-pushed
the
adding_ie_panda
branch
from
b92d04f to
77e5fcc
Compare
|
Question for the maintainers of this repo: I'm wondering whether there is a better way to manage the authorization token: wouldn't be better storing it in HA until it's about to expire, so every waste schedule refresh request won't call the authentication API all the time? |
|
Thanks for your contribution. It's once a day, so I don't think it's that big of a deal, but you could store the token as an attribute of the source object so it would not call the API every day but just on HA reboot or if it expires. Storing it directly in HA so it isn't called even on reboot isn't that straight forward, and we do not have a good approach for that. I'll merge this as is for now, if you'd like to redesign it this way feel free to do so and open a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented source for Panda Waste, Ireland.
Fixes #2894.