Fixes made while experimenting #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidtheclark
force-pushed
the
integration-improvements
branch
from
3047079 to
a3913a8
Compare
jfurrow
approved these changes
Jul 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying this out on a real site outside of this repository, I came across a number of problems to fix.
wrapperPath.excludefrom Babel Batfish'ssrc/files when they are withinnode_modules(when Batfish is a dependency).inlineJsoption to provide inline JS. The problem with using react-helmet directly was that on the development server inlined scripts were not inserted into the<head>and executed before React rendered. This divergence between the development server and the static site wasn't ok with me. Modified theinline-jsexample to use the new option, and changed docs.externalsRegExp during the static build. I kept getting React and UglifyJS in there — not what I wanted.@jfurrow for review. Could you double-check a few of the experiments, make sure I didn't break them?