Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent FOUC from page-specific CSS #77

Merged
merged 1 commit into from
Jul 13, 2017
Merged

Conversation

davidtheclark
Copy link
Contributor

Closes #71.

If/when a solution to nfl/react-helmet#297 gets released, we might be able to revert this stuff. But until then, I think this gets rid of the flash-of-unstyled-content when you dynamically load a page with page-specific CSS.

@jfurrow for review, since I was running with your react-page-components example.

@davidtheclark davidtheclark requested a review from jfurrow July 13, 2017 17:50
Copy link
Contributor

@jfurrow jfurrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoa, this is awesome. Great work!

@davidtheclark davidtheclark merged commit d2a62a6 into master Jul 13, 2017
@davidtheclark davidtheclark deleted the 71-page-css-fouc branch July 13, 2017 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants