Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve GeoJSON and image source handling #164

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Conversation

ntadej
Copy link
Collaborator

@ntadej ntadej commented Aug 30, 2024

  • Make sure GeoJSON is properly parsed. This is a bit hacky as it has to go QJSValue -> QVariant -> QJsonDocument -> QString and then JSON is again parsed by MapLibre, but this works. It can be improved in the future if needed.
  • Add ImageParameter to be able to add an image from Qt resources system (or local file) directly.

Implicitly closes #145 as I can not reproduce the issue.

@ntadej ntadej requested review from louwers and birkskyum August 30, 2024 21:22
@ntadej ntadej merged commit b2b74d6 into maplibre:main Sep 6, 2024
42 checks passed
@ntadej ntadej deleted the fix-img branch September 6, 2024 18:04
@ntadej ntadej added this to the 3.0 milestone Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add icon in map
2 participants