Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor pre-commit-config change #3251

Merged
merged 2 commits into from
Mar 6, 2025
Merged

Minor pre-commit-config change #3251

merged 2 commits into from
Mar 6, 2025

Conversation

nyurik
Copy link
Member

@nyurik nyurik commented Feb 24, 2025

Make sure to view the diff without whitespaces, or else it gets a bit messy

  • reformatted yaml
  • added a few standard checks (are they all ok?)
    • mixed to lf lineendings -- shouldn't git auto-handle this for the users?
    • big file exception? this repo seems to have a lot of big files (sigh), so not certain
  • sorted a few things

@nyurik nyurik requested a review from louwers February 24, 2025 06:13
@nyurik nyurik force-pushed the lints branch 3 times, most recently from 78e4b64 to 0851c8b Compare February 24, 2025 06:22
Copy link

Bloaty Results (iOS) 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-3251-compared-to-main.txt

Copy link

Bloaty Results 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-3251-compared-to-main.txt

Compared to d387090 (legacy)

    FILE SIZE        VM SIZE    
 --------------  -------------- 
   +31% +36.2Mi  +438% +26.2Mi    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-3251-compared-to-legacy.txt

Copy link

Benchmark Results ⚡

Benchmark                                                     Time             CPU      Time Old      Time New       CPU Old       CPU New
------------------------------------------------------------------------------------------------------------------------------------------
OVERALL_GEOMEAN                                            -0.0034         -0.0038             0             0             0             0

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/benchmark-results/pr-3251-compared-to-main.txt

@nyurik nyurik requested a review from louwers March 5, 2025 22:15
@louwers louwers enabled auto-merge (squash) March 6, 2025 17:44
@louwers louwers merged commit aa0fa21 into maplibre:main Mar 6, 2025
49 checks passed
@nyurik nyurik deleted the lints branch March 6, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants