Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Rust to build core as a static lib #3283

Merged
merged 2 commits into from
Mar 7, 2025
Merged

Allow Rust to build core as a static lib #3283

merged 2 commits into from
Mar 7, 2025

Conversation

nyurik
Copy link
Member

@nyurik nyurik commented Mar 6, 2025

No description provided.

@nyurik nyurik requested a review from louwers March 6, 2025 00:14
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.03%. Comparing base (18245ef) to head (41fa1ea).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3283   +/-   ##
=======================================
  Coverage   86.02%   86.03%           
=======================================
  Files         587      587           
  Lines       29890    29890           
=======================================
+ Hits        25714    25715    +1     
+ Misses       4176     4175    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

github-actions bot commented Mar 6, 2025

Bloaty Results 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-3283-compared-to-main.txt

Compared to d387090 (legacy)

    FILE SIZE        VM SIZE    
 --------------  -------------- 
   +32% +36.5Mi  +439% +26.3Mi    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-3283-compared-to-legacy.txt

Copy link

github-actions bot commented Mar 6, 2025

Benchmark Results ⚡

Benchmark                                                     Time             CPU      Time Old      Time New       CPU Old       CPU New
------------------------------------------------------------------------------------------------------------------------------------------
OVERALL_GEOMEAN                                            +0.0090         +0.0089             0             0             0             0

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/benchmark-results/pr-3283-compared-to-main.txt

@louwers louwers enabled auto-merge (squash) March 6, 2025 23:03
@louwers louwers merged commit b3fc9a7 into main Mar 7, 2025
50 checks passed
@louwers louwers deleted the rust-wrp-alpha branch March 7, 2025 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants