Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip punctuation from attribution #3287

Merged

Conversation

ianthetechie
Copy link
Collaborator

Punctuation like commas, semicolons, etc. are fairly common ways of formatting attribution on the web. However, this looks

Example attribution string:

<a href=\"https://stadiamaps.com/\" target=\"_blank\">&copy; Stadia Maps</a> &amp; <a href=\"https://stamen.com\" target=\"_blank\">&copy; Stamen Design</a>; <a href=\"https://openmaptiles.org/\" target=\"_blank\">&copy; OpenMapTiles</a>; <a href=\"https://www.openstreetmap.org/copyright\" target=\"_blank\">&copy; OpenStreetMap</a>.

Here's a pathological example of a rendering fail in MapLibre Native on iOS. I expect we'll need to do a similar fix on Android too.

image

Thanks to @Archdoog for pointing this out!

@ianthetechie ianthetechie requested review from louwers and Archdoog March 6, 2025 13:29
@louwers louwers added the iOS label Mar 6, 2025
@louwers louwers enabled auto-merge (squash) March 6, 2025 13:51
Copy link

github-actions bot commented Mar 6, 2025

Bloaty Results (iOS) 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%    +200  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-3287-compared-to-main.txt

@louwers louwers merged commit a188663 into maplibre:main Mar 6, 2025
40 checks passed
@ianthetechie ianthetechie deleted the strip-punctuation-from-attribution branch March 6, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

2 participants