#3304 - Initial resolution for local pmtiles asset, likely better resolution would be upstream in providers. #3305
+73
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…would be upstream in providers.
for more information, see https://pre-commit.ci
|
Not sure if this is something that should be implemented in the PMTiles library itself? (cc @bdon) @zach-snell Can you provide some more details in what cases the current implementation is problematic? |
|
This was an issue when loading PMTiles directly as an asset on Android. i.e. pmtiles://asset://world.pmtiles In this use case the Android Asset Provider would return the full file without respecting the dataRange concept and break the current implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.