Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #3035 which was causing memory growth issue #3315

Merged
merged 2 commits into from
Mar 17, 2025

Conversation

louwers
Copy link
Collaborator

@louwers louwers commented Mar 17, 2025

No description provided.

@louwers louwers requested a review from TimSylvester March 17, 2025 11:04
Copy link

Bloaty Results 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  -0.1%  -118Ki  +0.0%    +224    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-3315-compared-to-main.txt

Compared to d387090 (legacy)

    FILE SIZE        VM SIZE    
 --------------  -------------- 
   +31% +36.4Mi  +439% +26.3Mi    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-3315-compared-to-legacy.txt

Copy link

Benchmark Results ⚡

Benchmark                                                     Time             CPU      Time Old      Time New       CPU Old       CPU New
------------------------------------------------------------------------------------------------------------------------------------------
OVERALL_GEOMEAN                                            -0.0048         -0.0050             0             0             0             0

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/benchmark-results/pr-3315-compared-to-main.txt

Copy link
Collaborator

@TimSylvester TimSylvester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bummer. I guess we'll wait for C++23 after all.

@louwers
Copy link
Collaborator Author

louwers commented Mar 17, 2025

@TimSylvester Yeah bummer! Do you think it is an issue with the library?

@louwers louwers merged commit 00956fa into maplibre:main Mar 17, 2025
55 checks passed
@TimSylvester
Copy link
Collaborator

Seems like it, I don't think anything changed about what's captured or stored, but I might have missed something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants