Fix Nano theme legibility #10433
Merged
Fix Nano theme legibility #10433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slax57
reviewed
Jan 6, 2025
| fontSize: 12, | ||
| h1: { fontSize: '7rem' }, | ||
| h2: { fontWeight: 400 }, | ||
| h3: { fontWeight: 500 }, | ||
| h4: { fontWeight: 700 }, | ||
| h5: { fontWeight: 700 }, | ||
| button: { textTransform: undefined }, |
There was a problem hiding this comment.
Button text is no longer uppercased. Is this intended? 🤔
Before
After
There was a problem hiding this comment.
Yes it is. I find it more legible like that.
slax57
approved these changes
Jan 6, 2025
slax57
changed the title
fzaninotto
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Apps using the Nano theme aren't very usable due to poor legibility of buttons and menus.
Solution
Tweak the theme for better legibility.
Before:
After: