Add B&W Theme #10523
Merged
Add B&W Theme #10523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djhi
reviewed
Feb 17, 2025
|
The color of the section items in the menu is defined in the Demo, not in the theme. The theme can't do much about it. |
djhi
reviewed
Feb 18, 2025
| margin: `0 ${SPACING}px`, | ||
| paddingRight: 0, | ||
| borderRadius: 5, | ||
| color: isDarkMode ? grey['200'] : common['black'], |
There was a problem hiding this comment.
The color of the section items in the menu is defined in the Demo, not in the theme. The theme can't do much about it.
Suggested change
| color: isDarkMode ? grey['200'] : common['black'], |
This is enough to fallback to the styles defined in the component while still respecting the theme colors according to my tests. Have I missed something? The BW theme is the only one where that happens btw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new, modern theme, inspired by Shadcn.