Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dollarPrefixForGlobalDirectives option #104

Merged
merged 3 commits into from
Sep 12, 2019

Conversation

yhatt
Copy link
Member

@yhatt yhatt commented Sep 11, 2019

It provides $ prefix for built-in global directives through custom directives in Marpit framework by enabling dollarPrefixForGlobalDirectives option. (false by default)

This option is to migrate syntax smoothly for user of GUI tools, such as Marp for VS Code. Marp CLI user has already noticed warnings by Marpit so no problems would expect even if disabled aliases by default.

In Marp for VS Code that warnings won't stand out, dollarPrefixForGlobalDirectives should set true by default to prevent confusion.

This option is for Marp team, and not recommend to Marp users. Therefore we would not document this to README.md.

ToDo

This option is for GUI users to migrate syntax smoothly. CLI user has
already noticed warnings by Marpit so no problems would expect even if
disabled aliases by default. In GUI tool that warnings won't stand out
such as Marp for VS Code, `dollarPrefixForGlobalDirectives` should set
`true` by default to prevent confusion.
@yhatt yhatt merged commit 27a5775 into master Sep 12, 2019
@yhatt yhatt deleted the dollar-prefixed-global-directives branch September 12, 2019 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant