Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh markdown preview on updating configuration #20

Merged
merged 3 commits into from
Apr 3, 2019

Conversation

yhatt
Copy link
Member

@yhatt yhatt commented Apr 3, 2019

The scaling bug reported in #8 could still see after changing zoom level. It would return immediately after editing.

The current VS Code cannot render updated Markdown preview with using changed configurations and I reported a request to microsoft/vscode#70936.

And now, it would be resolved by executing markdown.preview.refresh command in VS Code 1.34. This PR will trigger refresh command on changing configurations that are affected to Marp preview.

Currently we have to wait to be released the next insider build for testing this.

@yhatt yhatt merged commit 3a33cb0 into master Apr 3, 2019
@yhatt yhatt deleted the refresh-markdown-on-updated-config branch April 3, 2019 05:10
@yhatt
Copy link
Member Author

yhatt commented Apr 5, 2019

UPDATE: I've tested this change in VSCode Insider 1.34 and it's getting work.

vscode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant