Disable Marpit polyfill when using VS Code >= 1.36 (Electron 4) #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhatt
commented
Jun 12, 2019
| // also has a glitch in video, and we have to wait for stable rendering until | ||
| // Electron 6. | ||
| const coercedVer = coerce(version) | ||
| const isRequiredPolyfill = coercedVer ? lt(coercedVer, '1.36.0') : false |
There was a problem hiding this comment.
VS Code seems not to provide API for getting Electron version. Instead we are using known VS Code version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've found just disabled @marp-team/marpit-svg-polyfill can fix the strange hit area reported at #45. This PR will detect the version of VS Code and toggle whether to apply polyfill.
Resolves #45.