fixed calculation error in mpesa_acces_token function #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the mpesa_access_token() had a bug in my system where the OAuth token would not refresh unless the request was sent 51 minutes after it expired. Now if no one used the system for an hour ,the token minutes would count to 59 then go back to zero since the minutes code would calculate the minutes above the hour making the old token "valid" since the minutes would be less than 50. I removed the modulus calculation so the minutes always go above 60.
removed the calculation error in mpesa_access_token()
|
Thanks for the catch!!! |
|
Hi, thanks for the merge its actually my first from a public repo that's
not mine. I love your library, it really helped me out with my projects
…On Tue, 3 Jan 2023 at 20:12, Martin Mogusu ***@***.***> wrote:
Merged #5 <#5> into
master.
—
Reply to this email directly, view it on GitHub
<#5 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUOCPOLQ4B6G4B6ABXXGDKDWQRMYLANCNFSM6AAAAAAQRYFDO4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi am a junior Django dev working on an e-commerce site and this bug really messed my tokens id love to get a response if the fix works for you