Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add metric for event cache and other missing metrics #4863

Merged
merged 8 commits into from
Feb 28, 2025
Merged

add metric for event cache and other missing metrics #4863

merged 8 commits into from
Feb 28, 2025

Conversation

modship
Copy link
Member

@modship modship commented Feb 20, 2025

  • document all added functions
  • try in sandbox /simulation/labnet
    • if part of node-launch, checked using the resync_check flag
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

@Leo-Besancon Leo-Besancon linked an issue Feb 25, 2025 that may be closed by this pull request
Add metrics to missing variable size structure #4862
Closed
19 tasks
@Leo-Besancon Leo-Besancon self-requested a review February 28, 2025 11:42
Leo-Besancon
Leo-Besancon approved these changes Feb 28, 2025
View reviewed changes
Copy link
Collaborator

@Leo-Besancon Leo-Besancon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for both @modship and I

@Leo-Besancon Leo-Besancon changed the title add metric for event cache add metric for event cache and other missing metrics Feb 28, 2025
@Leo-Besancon Leo-Besancon merged commit 2a8b9ac into mainnet_2_3 Feb 28, 2025
12 checks passed
Leo-Besancon added a commit that referenced this pull request Feb 28, 2025
@modship @Leo-Besancon
add metric for event cache and other missing metrics (#4863)
692df58 
* add metric for event cache

* Fix sub metrics

* Add metrics for massa-db-worker change history sizes

* Add lru_cache_memory_usage metric

* Disable db metrics for tests

* Refactor db metrics & lock handling

* Review comment

* Add active history events len

---------

Co-authored-by: Leo-Besancon <lb@massa.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leo-Besancon Leo-Besancon Leo-Besancon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add metrics to missing variable size structure
2 participants
@modship @Leo-Besancon