Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package.json exports property #94

Merged
merged 2 commits into from
Apr 9, 2022
Merged

Conversation

jirihon
Copy link
Contributor

@jirihon jirihon commented Apr 6, 2022

This allows modern build systems (vite) to properly use the correct module type (ESM). See chartjs/Chart.js#9597 for more details. It would be great to add the same exports property also to the other mathigon packages.

jirihon and others added 2 commits April 6, 2022 11:46
This allows modern build systems (vite) to properly use the correct module type (ESM). See sveltejs/kit#928 for more details.
@plegner plegner merged commit 5592f04 into mathigon:master Apr 9, 2022
@plegner
Copy link
Member

plegner commented Apr 9, 2022

Thanks @jirihon! merged, except for the type: module property which breaks existing imports in other repos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants