Introduce a Prompting command 😉 #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattbierner
requested changes
Apr 2, 2019
package.json
Outdated
| }, | ||
| "keybindings": [ | ||
| { | ||
| "mac": "cmd+[Period]", |
There was a problem hiding this comment.
This keybinding is already used to trigger code actions. Any ideas for a different one that does not conflict with VS Code's built-in keybindings?
There was a problem hiding this comment.
Didnt know about that one! :)
There was a problem hiding this comment.
I tried out cmd+[Minus] on my computer, what do you think about that one?
(this is cmd+ ) on my french keyboard)
AdrieanKhisbe
force-pushed
the
prompting-command
branch
from
d37851d to
75cf19e
Compare
AdrieanKhisbe
force-pushed
the
prompting-command
branch
from
75cf19e to
3ddd93c
Compare
|
@mattbierner I take into account your reviews, and add some improvement. Also rebased to fix conflict |
|
Thanks! Will publish updated extension shortly |
|
@mattbierner Awesome!! 🙌 =) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add feature to prompt for emoji to insert either in editor or in terminal 💻
This comes in endy notably from writing commits from the commandline in the embedded terminal 😉