-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get CI up and running again #33
Conversation
OllyK
commented
Sep 2, 2024
- Closes CI: Build runs not working as expected #18
- Adds a basic workflow to install package and run tests
- Adds a few tests
- Other CI actions still need to be disabled by maintainers using these instructions
e10b174
to
2b0012e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few questions on the tests and CI configuration. QOL improvements are amazing, and eventually we can be more specific with lower bound versions of packages.
Hi @mb010 , do you want me to just delete the other failing GitHub workflows or are you happy to disable them for now? |
Deleting them is fine. I'd rather have one system that works than a bunch that feel like they need to be maintained, when they're outdated. Happy to merge with the deletions done and the last update to the second test target shape made. |
LGTM |