Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get CI up and running again #33

Merged
merged 11 commits into from
Sep 4, 2024
Merged

Get CI up and running again #33

merged 11 commits into from
Sep 4, 2024

Conversation

OllyK
Copy link
Contributor

@OllyK OllyK commented Sep 2, 2024

@OllyK OllyK force-pushed the 18-fix-ci branch 2 times, most recently from e10b174 to 2b0012e Compare September 3, 2024 08:55
Copy link
Owner

@mb010 mb010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few questions on the tests and CI configuration. QOL improvements are amazing, and eventually we can be more specific with lower bound versions of packages.

@OllyK
Copy link
Contributor Author

OllyK commented Sep 4, 2024

Hi @mb010 , do you want me to just delete the other failing GitHub workflows or are you happy to disable them for now?

@mb010
Copy link
Owner

mb010 commented Sep 4, 2024

Deleting them is fine. I'd rather have one system that works than a bunch that feel like they need to be maintained, when they're outdated. Happy to merge with the deletions done and the last update to the second test target shape made.

@mb010
Copy link
Owner

mb010 commented Sep 4, 2024

LGTM

@mb010 mb010 merged commit 4dd14b7 into mb010:main Sep 4, 2024
0 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: Build runs not working as expected
2 participants