Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle multiple attribute values with the same name instead of concatenating them #67

Merged
merged 3 commits into from
Aug 5, 2024

Conversation

fumieval
Copy link
Contributor

@fumieval fumieval commented Aug 2, 2024

Summary

For example, this allows having multiple role attributes assigned to one user. (Otherwise role names are literally concatenated, which is a rather surprising behaviour)

Checklist

  • All definitions are documented with Haddock-style comments.
  • All exported definitions have @since annotations.
  • Code is formatted in line with the existing code.
  • The changelog has been updated.

@github-actions github-actions bot requested a review from mbg August 2, 2024 04:32
Copy link
Owner

@mbg mbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a sensible change given that the spec notes that multiple AttributeValue elements are allowed.

Just one minor suggestion for improving one of the docs comments. Otherwise this looks good to me, thank you!

Co-authored-by: Michael B. Gale <mbg@github.com>
@mbg mbg merged commit db3829c into mbg:master Aug 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants