Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Res is not defined #62

Closed
PythonCoderAS opened this issue Feb 27, 2022 · 0 comments · Fixed by #63
Closed

Res is not defined #62

PythonCoderAS opened this issue Feb 27, 2022 · 0 comments · Fixed by #63

Comments

@PythonCoderAS
Copy link
Contributor

When I made the code-move, I didn't realize res was declared and didn't re-declare it. So the refresh token method will error 100% of the time.
@PythonCoderAS PythonCoderAS mentioned this issue Feb 27, 2022
Merged
@md-y md-y closed this as completed in #63 Mar 7, 2022
Stevox404 added a commit to Stevox404/mangadex-full-api that referenced this issue Oct 4, 2022
@Stevox404 @PythonCoderAS
@md-y @Nowaaru @dispatchrabbi @spacehamster
Md y master update (#2)
2c8e30d 
* Add support for creating mangas and covers (md-y#56)

* Add support for creating mangas and covers

* Update types

* Add support for author creation

* Modify manga create to work with LocalizedStrings.

* Add support for not using localized strings

* Add support for updating.

* Add back constructor method

* Revert _parse and update types

Co-authored-by: md-y <midymyth@gmail.com>

* Add missing imports

* Add JSDOC Documentation

* Update github actions

* Remove left over page arrays

* Update types for 6866f92

* Add tests to GH actions & make auth based on env

* Update minimum node engine version to v12

* Add mocha tests badge

* Add test retries and node 12 support

* Add method for requesting total amount of search results (md-y#57)

* Update types for 6931667

* Update browser info in readme

* Add readableAt, locale, and mangaUpdates fields

* Update package to 5.9.0

* Update types for b8147c8

* Update package homepage and fix gh action

* Update package lock for 369bf09

* Add return type for getTotalSearchResults

* Update types for 1c0ea44

* Create npm-publish.yml

* Fix publish workflow

* Log X-Request-ID

* Allow tests to run on pull requests

* Add chapterNumbersResetOnNewVolume, availableTranslatedLanguages, and state fields to Manga

* Update types for 91181cf

* Update package to 5.10.0

* Update package lock for 6a5793c

* Move refresh token logic to another method

This way, I can call the refresh token method whenever needed, even if I shouldn't need to.

* make `getMultiple` include pornographic mangas

* Assign res as a const

Fix md-y#62

* Add contentRatings parameter to Manga.getRandom

* Update types for 8ec204e

* Fix getRandom docs and update npm version

* Update package lock for b4e2622

* Manually update types because the workflow did not trigger

* Fix getReadChapters

* Move getReadChapters() to login.test.js to be with other auth-required tests

* Skip auth test for PRs since secrets are unavailable

* Update npm

* Update package lock for c4396fd

* Added latestUploadedChapter field.

* Convert latestUploadedChapter to a Relationship

* Update types for b33299b

* Add support for tags in searches

* Update npm

* Update package lock for 00a8ec6

Co-authored-by: PythonCoderAS <sarkaraoyan@gmail.com>
Co-authored-by: md-y <midymyth@gmail.com>
Co-authored-by: md-y <md-y@users.noreply.github.com>
Co-authored-by: PythonCoderAS <13932583+PythonCoderAS@users.noreply.github.com>
Co-authored-by: Nowaaru <zackyboy135@gmail.com>
Co-authored-by: Eli Morris-Heft <eli.morris.heft@gmail.com>
Co-authored-by: spacehamster <mail.spacehamster@gmail.com>
Co-authored-by: md-y <15069105+md-y@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Assign res as a const
1 participant
@PythonCoderAS