Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal error #66

Closed
marcelloh opened this issue Feb 12, 2025 · 4 comments · Fixed by #67
Closed

Internal error #66

marcelloh opened this issue Feb 12, 2025 · 4 comments · Fixed by #67

Comments

@marcelloh
Copy link

marcelloh commented Feb 12, 2025 •
edited
Loading

internal error: package "errors" without types was imported from ...

cmd: unconvert -v ./...

Go version 1.24 (MacOS)
@JetSetIlly
Copy link

I get a similar error. The reported package is different but the failure is still an "internal error"

Also Go version 1.24.0

dmitshur added a commit that referenced this issue Feb 16, 2025
@dmitshur
all: update go and dependency versions [generated]
9ddfa8e 
Fixes #66.

[git-generate]
go get go@1.23.0 toolchain@none golang.org/x/tools@v0.30.0 golang.org/x/text@v0.22.0
go mod tidy
sed -i '' 's/21/24/' .github/workflows/test.yml
sed -i '' 's/20/23/' .github/workflows/test.yml
@dmitshur dmitshur mentioned this issue Feb 16, 2025
Merged
@JetSetIlly
Copy link

JetSetIlly commented Feb 16, 2025 •
edited
Loading

@mdempsky @mvdan @dmitshur This issue was closed by #67 but it does not fix it.

I still get the same error with go1.24.0 unfortunately.

I've updated the tool with go install github.com/mdempsky/unconvert@latest

@dmitshur
Copy link
Collaborator

dmitshur commented Feb 16, 2025 •
edited
Loading

@JetSetIlly Does go version -m $(which unconvert) print v0.0.0-20250216222326-4a038b3d31f5 or an older version? The cache of the latest version query might not have worn off yet, meaning you'd need to explicitly request the new version with go install github.com/mdempsky/unconvert@4a038b3d31f5 or equivalent for a little while.

@JetSetIlly
Copy link

JetSetIlly commented Feb 16, 2025 •
edited by dmitshur
Loading

@JetSetIlly Does go version -m $(which unconvert) print v0.0.0-20250216222326-4a038b3d31f5 or an older version? The cache of the latest version query might not have worn off yet, meaning you'd need to explicitly request the new version with go install github.com/mdempsky/unconvert@4a038b3d31f5 or equivalent for a little while.

Great call. That works. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

all: update go and dependency versions [generated] mdempsky/unconvert
3 participants
@dmitshur @marcelloh @JetSetIlly