Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WebDriver BiDi data #26203

Merged
merged 1 commit into from
Mar 18, 2025
Merged

Update WebDriver BiDi data #26203

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions webdriver/bidi.json
View file
Original file line number Diff line number Diff line change
@@ -1958,11 +1958,11 @@
"edge": "mirror",
"firefox": [
{
"version_added": "114"
"version_added": "136"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@whimboo Can you confirm that addPreloadScript() is only fully supported from Firefox 136 (previously the sheet said 114)?

PS: Looks like the sync is doing it's job.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We recently added support for the userContexts argument which was added to the BiDi spec after we marked it as done. You should see a similar change for browsingContext.setViewport as well.

Is it ok to reorder the version numbers for an API in the spreadsheet or should I avoid that? What should be in brackets and what not to make it helpful for you.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the reason browsingContext.setViewport doesn't show up here is that its status is set to "Partial", so we're just using the earliest version. If its status was "Complete", we would set a partial support entry for Firefox 117 and a full support entry for Firefox 138.

As for determining the versions, the script is currently ignoring the brackets, so in this example, it extracts [117, 127, 138], and uses the lowest version for partial support, and if status is "Complete", the highest version for full support.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know that it doesn't matter how the versions are listed. So I will re-org them most likely for our Firefox related status entries. Thanks!

I wonder how we should handle situations when an API gets a new parameter added at a later time while it is already marked as done. Would just adding a new version to the list be enough to get the version for a complete implementation updated?

},
{
"version_added": "112",
"version_removed": "114",
"version_removed": "136",
"partial_implementation": true,
"notes": "Basic support (see [bug 1806407](https://bugzil.la/1806407))"
}