Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add accessibility info to <progress> doc #10707

Merged
merged 3 commits into from
Dec 1, 2021
Merged

Conversation

dev-nicolaos
Copy link
Contributor

Summary

Adds content outlining common accessibility concerns when using the HTML <progress> element as described in various specs.

Motivation

To increase awareness of how to use the <progress> element in an accessible way.

Supporting details

https://www.w3.org/TR/wai-aria-practices-1.2/#naming_role_guidance (scroll down to progressbar role)
https://www.w3.org/TR/wai-aria-1.2/#progressbar
https://html.spec.whatwg.org/multipage/form-elements.html#the-progress-element

Related issues

None that I could find

Metadata

  • Adds a new document
  • Rewrites (or significantly expands) a document
  • Fixes a typo, bug, or other error

@github-actions github-actions bot added the Content:HTML Hypertext Markup Language docs label Nov 23, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Nov 23, 2021

Preview URLs

Flaws

URL: /en-US/docs/Web/HTML/Element/progress
Title: <progress>: The Progress Indicator element
on GitHub
Flaw count: 4

  • macros:
    • /en-US/docs/Web/CSS/::-ms-fill does not exist
  • broken_links:
    • Can't resolve /en-US/docs/Web/Accessibility/ARIA/Attributes/aria-labelledby
    • Can't resolve /en-US/docs/Web/Accessibility/ARIA/Attributes/aria-label
    • Can't resolve /en-US/docs/Web/Accessibility/ARIA/Attributes/aria_busy

External URLs

URL: /en-US/docs/Web/HTML/Element/progress
Title: <progress>: The Progress Indicator element
on GitHub

No new external URLs

(this comment was updated 2021-11-24 17:30:20.663763)

@dev-nicolaos dev-nicolaos marked this pull request as ready for review November 23, 2021 00:16
@dev-nicolaos dev-nicolaos requested a review from a team as a code owner November 23, 2021 00:16
@dev-nicolaos dev-nicolaos requested review from estelle and removed request for a team November 23, 2021 00:16
@dev-nicolaos
Copy link
Contributor Author

@estelle I think this PR is ready to merge, what do you think?

Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic!

@estelle
Copy link
Member

estelle commented Dec 1, 2021

Thank you!

@estelle estelle merged commit 563b906 into mdn:main Dec 1, 2021
@dev-nicolaos dev-nicolaos deleted the patch-2 branch December 1, 2021 15:02
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Content:HTML Hypertext Markup Language docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants