Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a note about htmlFor that trips you when you want to set for on a label #10882

Merged
merged 2 commits into from
Nov 30, 2021
Merged

Add a note about htmlFor that trips you when you want to set for on a label #10882

merged 2 commits into from
Nov 30, 2021

Conversation

tomayac
Copy link
Contributor

@tomayac tomayac commented Nov 30, 2021

Summary

Add a note about htmlFor that trips you when you want to set for on a label

Motivation

Reduce developer confusion.

Supporting details

Related issues

Metadata

  • Adds a new document
  • Rewrites (or significantly expands) a document
  • Fixes a typo, bug, or other error

@tomayac tomayac requested review from a team as code owners November 30, 2021 14:31
@tomayac tomayac requested review from ericwbailey and sideshowbarker and removed request for a team November 30, 2021 14:31
@github-actions github-actions bot added Content:HTML Hypertext Markup Language docs Content:WebAPI Web API docs labels Nov 30, 2021
@github-actions
Copy link
Contributor

Preview URLs

Flaws

None! 🎉

External URLs

URL: /en-US/docs/Web/API/HTMLLabelElement
Title: HTMLLabelElement
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTML/Element/label
Title: <label>: The Input Label element
on GitHub

No new external URLs

ericwbailey
ericwbailey approved these changes Nov 30, 2021
View reviewed changes
Copy link
Member

@ericwbailey ericwbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does what it says on the tin!

@ericwbailey ericwbailey merged commit 8720791 into mdn:main Nov 30, 2021
@rayw000 rayw000 mentioned this pull request Dec 1, 2021
Closed
3 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ericwbailey ericwbailey ericwbailey approved these changes

@sideshowbarker sideshowbarker Awaiting requested review from sideshowbarker sideshowbarker is a code owner automatically assigned from mdn/yari-content-web-api

Assignees
No one assigned
Labels
Content:HTML Hypertext Markup Language docs Content:WebAPI Web API docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomayac @ericwbailey