Fix inline styles 2 #5657

hamishwillee · 2021-06-04T04:07:14Z

Part of fixing #5438

hamishwillee · 2021-06-04T04:08:30Z

files/en-us/web/api/webxr_device_api/inputs/index.html

-<figcaption><strong>The coordinate system for the right hand's grip space.</strong></figcaption>
+<strong>Figure: The coordinate system for the left hand's grip space.</strong>
+
+<img width="600px" alt="A diagram showing how the grip space indicates the local coordinate system for the player's hand relative to the world." src="dark_left.svg">


These images are SVG so they expand full screen,, which looks ridiculous. I have capped size here explicitly but we would be wise to have some infrastructure in yari to pin their size.

Thoughts?

These images are SVG so they expand full screen,, which looks ridiculous. I have capped size here explicitly but we would be wise to have some infrastructure in yari to pin their size.

Thoughts?

I personally have no insights to offer on how to solve that — but I agree about the problem

Thanks very much. Me either. Let's see what others think mdn/yari#3970

github-actions · 2021-06-04T04:09:39Z

Preview URLs

Flaws

Note! 4 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/WebVR_API/Using_the_WebVR_API
Title: Using the WebVR API
on GitHub
Flaw count: 1

macros:
- wrong xref macro used (consider changing which macro you use)

URL: /en-US/docs/Web/API/WebXR_Device_API
Title: WebXR Device API
on GitHub
Flaw count: 6

macros:
- /en-US/docs/Web/API/WebGLRenderingContextBase/makeXRCompatibile does not exist
- /en-US/docs/Web/API/WebGLContextAttributes/xrCompatible does not exist
broken_links:
- Can't resolve /en-US/docs/Web/API/WebXR_Device_API/Input_profiles
- Can't resolve /en-US/docs/Web/WebXR_Device_API/Gamepads
- Can't resolve /en-US/docs/Web/Media/3D_audio
- Can't resolve /en-US/docs/Web/Media/3D_video

URL: /en-US/docs/Web/API/WebXR_Device_API/Movement_and_motion
Title: Movement, orientation, and motion: A WebXR example
on GitHub
Flaw count: 1

macros:
- /en-US/docs/Web/API/XRWebGLLayer/viewport does not exist

URL: /en-US/docs/Web/API/WebXR_Device_API/Inputs
Title: Inputs and input sources
on GitHub
Flaw count: 16

macros:
- /en-US/docs/Web/API/XRInputSource/gamepad does not exist
- /en-US/docs/Web/API/XRInputSource/gamepad does not exist
- /en-US/docs/Web/API/XRInputSourceChangeEvent does not exist
- /en-US/docs/Web/API/XRInputSourceChangeEvent/session does not exist
- /en-US/docs/Web/API/XRInputSourceChangeEvent/added does not exist
- and 6 more flaws omitted
broken_links:
- Can't resolve /en-US/docs/Web/WebXR_Device_API/Gamepads
- Can't resolve /en-US/docs/Web/API/WebXR_Device_API/Input_profiles
- Can't resolve /en-US/docs/Web/WebXR_Device_API/Gamepads
- Can't resolve /en-US/docs/Web/API/WebXR_Device_API/Input_profiles
- Can't resolve /en-US/docs/Web/WebXR_Device_API/Gamepads

URL: /en-US/docs/Web/API/WebXR_Device_API/Fundamentals
Title: Fundamentals of WebXR
on GitHub
Flaw count: 1

broken_links:
- Can't resolve /en-US/docs/Web/API/WebXR_Device_API/Augmented_reality

URL: /en-US/docs/Web/API/WebVTT_API
Title: Web Video Text Tracks Format (WebVTT)
on GitHub
Flaw count: 23

macros:
- /en-US/docs/Web/API/VTTCue/align does not exist
bad_bcd_links:
- no explanation!
- no explanation!
- no explanation!
- no explanation!
- no explanation!
- and 17 more flaws omitted

URL: /en-US/docs/Web/API/WebSockets_API/Writing_WebSocket_servers
Title: Writing WebSocket servers
on GitHub
Flaw count: 1

broken_links:
- Can't resolve /en-US/docs/Web/JavaScript/Server-Side_JavaScript

External URLs

URL: /en-US/docs/Web/API/WebVR_API
Title: WebVR API
on GitHub

https://webvr.directory/ (1 time) (Note! This may be a new URL 👀)

URL: /en-US/docs/Web/API/WebVR_API/Using_the_WebVR_API
Title: Using the WebVR API
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/WebXR_Device_API
Title: WebXR Device API
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/WebXR_Device_API/Movement_and_motion
Title: Movement, orientation, and motion: A WebXR example
on GitHub

https://github.com/immersive-web/webxr-polyfill/ (1 time) (Note! This may be a new URL 👀)
https://glmatrix.net/ (1 time) (Note! This may be a new URL 👀)
https://threejs.org/ (1 time) (Note! This may be a new URL 👀)
https://webglfundamentals.org (1 time) (Note! This may be a new URL 👀)

URL: /en-US/docs/Web/API/WebXR_Device_API/Cameras
Title: Viewpoints and viewers: Simulating cameras in WebXR
on GitHub

https://glmatrix.net/ (3 times) (Note! This may be a new URL 👀)
https://glmatrix.net/docs/module-mat4.html (1 time) (Note! This may be a new URL 👀)

URL: /en-US/docs/Web/API/WebXR_Device_API/Lighting
Title: Lighting a WebXR setting
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/WebXR_Device_API/Inputs
Title: Inputs and input sources
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/WebXR_Device_API/Rendering
Title: Rendering and the WebXR frame animation callback
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/WebXR_Device_API/Fundamentals
Title: Fundamentals of WebXR
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/WebVTT_API
Title: Web Video Text Tracks Format (WebVTT)
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/WebSockets_API/Writing_WebSocket_servers
Title: Writing WebSocket servers
on GitHub

https://datatracker.ietf.org/doc/rfc6455/?include_text=1 (1 time) (Note! This may be a new URL 👀)
https://en.wikipedia.org/wiki/Base64 (1 time) (Note! This may be a new URL 👀)
https://en.wikipedia.org/wiki/Magic_string (1 time) (Note! This may be a new URL 👀)
https://en.wikipedia.org/wiki/SHA-1 (1 time) (Note! This may be a new URL 👀)
https://www.iana.org/assignments/websocket/websocket.xml (1 time) (Note! This may be a new URL 👀)

(this comment was updated 2021-06-04 04:38:44.622972)

hamishwillee added 4 commits June 4, 2021 13:47

WebXR device - rendering: remove inline styles

a574b53

WebXr device - move and motion: remove inline styles

598ba8c

WebXR device - lighting: remove inline styles

19403f3

WebXR device inputs: remove inline styles

6dfdb0e

hamishwillee commented Jun 4, 2021

View reviewed changes

hamishwillee added 7 commits June 4, 2021 14:12

WebXR device API - remove inline styles

6b9cf2b

WebXR device fundamentals: remove inline styles

beeb244

WebXR device - cameras: remove inline styles

aabae20

Webvtt api: remove inline styles

9cfaee7

Using WebVR API: remove inline styles

2bc147e

WebVR api: remove inline styles

0b0cb39

Websockets - writing servers: remove inline styles

67505b6

hamishwillee marked this pull request as ready for review June 4, 2021 04:37

hamishwillee requested a review from a team as a code owner June 4, 2021 04:37

hamishwillee requested review from sideshowbarker and wbamberg and removed request for a team June 4, 2021 04:37

sideshowbarker approved these changes Jun 4, 2021

View reviewed changes

sideshowbarker merged commit 3e8265d into mdn:main Jun 4, 2021

github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix inline styles 2 #5657

Fix inline styles 2 #5657

hamishwillee commented Jun 4, 2021

hamishwillee Jun 4, 2021

sideshowbarker Jun 4, 2021

hamishwillee Jun 4, 2021

github-actions bot commented Jun 4, 2021 •

edited

Loading

Fix inline styles 2 #5657

Fix inline styles 2 #5657

Conversation

hamishwillee commented Jun 4, 2021

hamishwillee Jun 4, 2021

Choose a reason for hiding this comment

sideshowbarker Jun 4, 2021

Choose a reason for hiding this comment

hamishwillee Jun 4, 2021

Choose a reason for hiding this comment

github-actions bot commented Jun 4, 2021 • edited Loading

Preview URLs

Flaws

External URLs

github-actions bot commented Jun 4, 2021 •

edited

Loading