Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML Element page template - update for browser-compat #6217

Merged
merged 8 commits into from
Jun 25, 2021
Merged

HTML Element page template - update for browser-compat #6217

merged 8 commits into from
Jun 25, 2021

Conversation

hamishwillee
Copy link
Collaborator

@hamishwillee hamishwillee commented Jun 22, 2021 •
edited
Loading

This updates the HTML element page template for improved front-matter information (in particular browser compat) and generally for best-practice.

@hamishwillee hamishwillee requested a review from a team as a code owner June 22, 2021 06:32
@hamishwillee hamishwillee requested review from Elchi3 and removed request for a team June 22, 2021 06:32
@hamishwillee hamishwillee mentioned this pull request Jun 22, 2021
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Jun 22, 2021 •
edited
Loading

Preview URLs

Flaws

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/MDN/Structures/Page_types/HTTP_header_page_template
Title: HTTP header page template
on GitHub
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: path.to.feature.NameOfTheHeader

URL: /en-US/docs/MDN/Structures/Page_types/API_property_subpage_template
Title: API property subpage template
on GitHub
Flaw count: 2

  • macros:
    • /en-us/docs/web/api/mdn (url: /en-US/docs/Web/API/MDN) does not exist
  • bad_bcd_queries:
    • No BCD data for query: path.to.feature.NameOfTheProperty

URL: /en-US/docs/MDN/Structures/Page_types/API_event_handler_subpage_template
Title: API event handler subpage template
on GitHub
Flaw count: 2

  • macros:
    • /en-us/docs/web/api/mdn (url: /en-US/docs/Web/API/MDN) does not exist
  • bad_bcd_queries:
    • No BCD data for query: path.to.feature.NameOfTheProperty

URL: /en-US/docs/MDN/Structures/Page_types/API_reference_page_template
Title: API reference page template
on GitHub
Flaw count: 10

  • macros:
    • /en-us/docs/web/api/mdn (url: /en-US/docs/Web/API/MDN) does not exist
    • /en-US/docs/Web/API/NameOfTheInterface/NameOfTheInterface does not exist
    • /en-US/docs/Web/API/NameOfTheInterface does not exist
    • /en-US/docs/Web/API/NameOfParentInterface does not exist
    • /en-US/docs/Web/API/NameOfTheInterface/property1 does not exist
    • and 4 more flaws omitted
  • bad_bcd_queries:
    • No BCD data for query: path.to.feature.NameOfTheInterface

URL: /en-US/docs/MDN/Structures/Page_types/API_constructor_subpage_template
Title: API constructor subpage template
on GitHub
Flaw count: 3

  • macros:
    • /en-us/docs/web/api/mdn (url: /en-US/docs/Web/API/MDN) does not exist
    • /en-US/docs/Web/API/%3Cem%3EName%3C/em%3EOf%3Cem%3ETheParentInterface%3C/em%3E does not exist
  • bad_bcd_queries:
    • No BCD data for query: path.to.feature.NameOfTheConstructor

URL: /en-US/docs/MDN/Structures/Page_types/API_method_subpage_template
Title: API method subpage template
on GitHub
Flaw count: 2

  • macros:
    • /en-us/docs/web/api/mdn (url: /en-US/docs/Web/API/MDN) does not exist
  • bad_bcd_queries:
    • No BCD data for query: path.to.feature.NameOfTheMethod

URL: /en-US/docs/MDN/Structures/Page_types/API_event_subpage_template
Title: API event subpage template
on GitHub
Flaw count: 2

  • macros:
    • /en-us/docs/web/api/mdn (url: /en-US/docs/Web/API/MDN) does not exist
  • bad_bcd_queries:
    • No BCD data for query: path.to.feature.NameOfTheEvent_event

URL: /en-US/docs/MDN/Structures/Page_types/HTML_element_page_template
Title: HTML element page template
on GitHub
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: path.to.feature.NameOfTheElement

URL: /en-US/docs/MDN/Structures/Page_types/API_landing_page_template
Title: API landing page template
on GitHub
Flaw count: 6

  • macros:
    • /en-us/docs/web/api/mdn (url: /en-US/docs/Web/API/MDN) does not exist
    • /en-US/docs/Web/API/NameOfTheInterface does not exist
    • /en-US/docs/Web/API/Addition1 does not exist
    • /en-US/docs/Web/API/Addition1 does not exist
  • bad_bcd_queries:
    • No BCD data for query: path.to.feature.Interface_1
    • No BCD data for query: path.to.feature.Interface_2

URL: /en-US/docs/MDN/Structures/Page_types/CSS_property_page_template
Title: CSS property page template
on GitHub
Flaw count: 4

  • macros:
    • /en-US/docs/Web/CSS/subvalue1 does not exist
    • /en-US/docs/Web/CSS/subvalue2 does not exist
    • `/home/runner/work/content/content/node_modules/@mdn/yari/kumascript/macros/CSSSyntax.ejs:1

1| <%
2| /*
3| Displays the syntax of a CSS property or descriptor
4|

No syntax found in DB for 'css_property_page_template'`

  • bad_bcd_queries:
    • No BCD data for query: path.to.feature.NameOfTheProperty

URL: /en-US/docs/MDN/Structures/Page_types/SVG_element_page_template
Title: SVG element page template
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/NameOfSVGDOMElement does not exist
  • bad_bcd_queries:
    • No BCD data for query: path.to.feature.NameOfTheElement

External URLs

URL: /en-US/docs/MDN/Structures/Page_types/HTTP_header_page_template
Title: HTTP header page template
on GitHub

No new external URLs

URL: /en-US/docs/MDN/Structures/Page_types/API_property_subpage_template
Title: API property subpage template
on GitHub

No new external URLs

URL: /en-US/docs/MDN/Structures/Page_types/API_event_handler_subpage_template
Title: API event handler subpage template
on GitHub

No new external URLs

URL: /en-US/docs/MDN/Structures/Page_types/API_reference_page_template
Title: API reference page template
on GitHub

No new external URLs

URL: /en-US/docs/MDN/Structures/Page_types/API_constructor_subpage_template
Title: API constructor subpage template
on GitHub

No new external URLs

URL: /en-US/docs/MDN/Structures/Page_types/API_method_subpage_template
Title: API method subpage template
on GitHub

No new external URLs

URL: /en-US/docs/MDN/Structures/Page_types/API_event_subpage_template
Title: API event subpage template
on GitHub

No new external URLs

URL: /en-US/docs/MDN/Structures/Page_types/HTML_element_page_template
Title: HTML element page template
on GitHub

No new external URLs

URL: /en-US/docs/MDN/Structures/Page_types/API_landing_page_template
Title: API landing page template
on GitHub

No new external URLs

URL: /en-US/docs/MDN/Structures/Page_types/CSS_property_page_template
Title: CSS property page template
on GitHub

No new external URLs

URL: /en-US/docs/MDN/Structures/Page_types/SVG_element_page_template
Title: SVG element page template
on GitHub

No new external URLs

URL: /en-US/docs/MDN/Structures/Page_types/ARIA_Page_Template
Title: ARIA page template
on GitHub

No new external URLs

(this comment was updated 2021-06-25 04:00:11.265428)

Elchi3
Elchi3 requested changes Jun 23, 2021
View reviewed changes
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Hamish, some comments.

hamishwillee and others added 7 commits June 25, 2021 13:38
@hamishwillee hamishwillee requested a review from Elchi3 June 25, 2021 03:59
@hamishwillee
Copy link
Collaborator Author

Thanks! I've accepted suggestions, removed draft macro from all the templates, fixed up copy paste error in front matter title for all templates. Removed the interactive example text.
Should be good.

Elchi3
Elchi3 approved these changes Jun 25, 2021
View reviewed changes
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you! 👍

@Elchi3 Elchi3 merged commit ecccb95 into mdn:main Jun 25, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@teoli2003 teoli2003 teoli2003 left review comments

@Elchi3 Elchi3 Elchi3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hamishwillee @Elchi3 @teoli2003