Skip to content
This repository was archived by the owner on Aug 26, 2022. It is now read-only.

Let's stop sending waffle flags in whoami #7883

Merged

Conversation

peterbe
Copy link
Contributor

@peterbe peterbe commented May 31, 2021

Fixes #7882

This is the before:
Screen Shot 2021-05-31 at 9 25 44 AM
Screen Shot 2021-05-31 at 9 26 09 AM

Let's remember to check back on those graphs after this change makes it into prod.

@codecov-commenter
Copy link

Codecov Report

Merging #7883 (7e48cfb) into master (d678bcc) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7883      +/-   ##
==========================================
+ Coverage   91.27%   91.29%   +0.02%     
==========================================
  Files         230      230              
  Lines       20288    20274      -14     
  Branches     1599     1590       -9     
==========================================
- Hits        18517    18509       -8     
+ Misses       1509     1505       -4     
+ Partials      262      260       -2     
Impacted Files Coverage Δ
kuma/api/v1/views.py 96.33% <ø> (+2.67%) ⬆️
kuma/api/v1/tests/test_views.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d678bcc...7e48cfb. Read the comment docs.

@peterbe peterbe requested a review from escattone June 1, 2021 11:08
Copy link
Contributor

@escattone escattone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works just fine, thanks so much @peterbe! It feels good to get rid of this.

@escattone escattone merged commit 8597dbf into mdn:master Jun 8, 2021
@peterbe peterbe deleted the 7882-lets-stop-sending-waffle-flags-in-whoami branch June 9, 2021 13:47
@peterbe
Copy link
Contributor Author

peterbe commented Jun 11, 2021

The times after:
Screen Shot 2021-06-11 at 8 03 24 AM

Screen Shot 2021-06-11 at 8 03 52 AM

That was entirely predictable. But. oh man does that feel good!!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Let's stop sending waffle flags in whoami
3 participants