Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add banner to localized pages #3588

Closed
escattone opened this issue Apr 21, 2021 · 14 comments · Fixed by #3658
Closed

add banner to localized pages #3588

escattone opened this issue Apr 21, 2021 · 14 comments · Fixed by #3658
Assignees
Labels
frontend general frontend issues p1 We will address this soon and will provide capacity from our team for it in the next few releases.

Comments

@escattone
Copy link
Contributor

escattone commented Apr 21, 2021

Intro

Let's add a banner to all localized pages for the 10 supported non-English locales. The banner has to account for two cases:

  1. pages within the 6 active locales: ru, ko, fr, ja, zh-CN, and zh-TW
  2. pages within the 4 inactive locales: de, es, pl, and pt-BR

Location and look

Screenshot 2021-04-07 at 17 28 23

Let's go with @dalexsy's second mockup:

  • Located just below the breadcrumb bar and much thinner than that bar
  • Left justified text
  • Highlighted background
    • active locales: light pastel yellow or whatever color @schalkneethling and @dalexsy feel is best
    • inactive locales: a color that provides more emphasis, that indicates more of a warning since these locales have no community maintaining them, perhaps a brighter yellow or very light red or whatever color @schalkneethling and @dalexsy feel is best

Text

Let's hard code the translations of the English text into the banner for each locale.

Active locales

Let's go with translations of @ddbeck's text for the 6 active locales (text below shown for French as an example):

This page was translated from English by the community. Learn more by joining the French community on MDN.

Where the language community links for each language would be as follows:

Inactive locales

Let's go with translations of @chrisdavidmills' text for the 4 inactive locales:

This page was translated from English by the community, but it is not actively maintained therefore it may be out-of-date. If you'd like to help maintain it, find out how to activate inactive locales.

@escattone escattone added the frontend general frontend issues label Apr 21, 2021
@escattone
Copy link
Contributor Author

@schalkneethling Could you take this one?

@escattone escattone added the p1 We will address this soon and will provide capacity from our team for it in the next few releases. label Apr 21, 2021
@escattone
Copy link
Contributor Author

escattone commented Apr 22, 2021

I think we could ask each of the respective localization communities within the active locales on https://github.com/mdn/content to provide translations of the text we've selected for the active locales, and I'm thinking we can find others to help us with translations for the text for the inactive locales (e.g., @Gregoor for de, and my wife could provide one for es 😄).

@SphinxKnight
Copy link
Member

If I may be of any help :) (I was just wandering across the repos)

This page was translated from English by the community. Learn more by joining the French community on MDN.

could be translated in French by

Cette page a été traduite à partir de l'anglais par la communauté. Vous pouvez également contribuer en rejoignant la communauté francophone sur MDN.

@schalkneethling
Copy link

Progress!

Screenshot 2021-04-29 at 15 37 48

@schalkneethling
Copy link

And some more progress 🙃

Screenshot of MDN Web Docs page showing a warning message for inactive locales

@schalkneethling
Copy link

Screenshot of active translation message on desktop

@escattone
Copy link
Contributor Author

@schalkneethling Exciting! Looks good so far! 🎉

@Gregoor
Copy link
Contributor

Gregoor commented Apr 29, 2021

Hey @schalkneethling, in case you still need deutsch, here's my attempt at speaking die Sprache:

This page was translated from English by the community, but it is not actively maintained therefore it may be out-of-date. If you'd like to help maintain it, find out how to activate inactive locales.

could be translated to

Der Inhalt dieser Seite wurde von der Community übersetzt, jedoch wird er nicht mehr aktiv gepflegt und kann daher veraltet sein. Wenn du mithelfen möchtest, kannst du hier herausfinden wie deaktivierte Übersetzung reaktiviert werden.

Tastes may vary (it feels a little wordy, but that's german for ya)

@schalkneethling
Copy link

Hey @schalkneethling, in case you still need deutsch, here's my attempt at speaking die Sprache:

This page was translated from English by the community, but it is not actively maintained therefore it may be out-of-date. If you'd like to help maintain it, find out how to activate inactive locales.

could be translated to

Der Inhalt dieser Seite wurde von der Community übersetzt, jedoch wird er nicht mehr aktiv gepflegt und kann daher veraltet sein. Wenn du mithelfen möchtest, kannst du hier herausfinden wie deaktivierte Übersetzung reaktiviert werden.

Tastes may vary (it feels a little wordy, but that's german for ya)

Vielen Dank, Gregor! I shall use it.

@hochan222
Copy link
Member

hochan222 commented May 3, 2021

I was just wandering across the repos too.

This page was translated from English by the community. Learn more by joining the Korean community on MDN.

could be translated in Korean by

이 페이지는 커뮤니티에서 영어로 번역되었습니다. MDN에서 한국 커뮤니티에 가입하여 자세히 알아보세요.


"Korean" (ko): TBD (@chrisdavidmills can provide this when it's ready)

@chrisdavidmills I hope it helped a little. :)

@schalkneethling
Copy link

I was just wandering across the repos too.

This page was translated from English by the community. Learn more by joining the Korean community on MDN.

could be translated in Korean by

이 페이지는 커뮤니티에서 영어로 번역되었습니다. MDN에서 한국 커뮤니티에 가입하여 자세히 알아보세요.

"Korean" (ko): TBD (@chrisdavidmills can provide this when it's ready)

@chrisdavidmills I hope it helped a little. :)

Nice, thank you so much @hochan222.

schalkneethling pushed a commit that referenced this issue May 3, 2021
Moves notecards into Yari.
Add localized content notes for active and inactive translated content.

Fix #3588
schalkneethling pushed a commit that referenced this issue May 5, 2021
* fix: localized content notes

Moves notecards into Yari.
Add localized content notes for active and inactive translated content.

Fix #3588

* changes based on review feedback

* update string for inactive locale note content for en-US

* changes based on review feedback

* Update client/src/document/molecules/localized-content-note/index.tsx

Co-authored-by: Peter Bengtsson <peterbe@mozilla.com>

* Update client/src/document/molecules/localized-content-note/index.tsx

Co-authored-by: Peter Bengtsson <peterbe@mozilla.com>

* prettier

Co-authored-by: Peter Bengtsson <peterbe@mozilla.com>
peterbe pushed a commit to peterbe/yari that referenced this issue Jun 1, 2021
* fix: localized content notes

Moves notecards into Yari.
Add localized content notes for active and inactive translated content.

Fix mdn#3588

* changes based on review feedback

* update string for inactive locale note content for en-US

* changes based on review feedback

* Update client/src/document/molecules/localized-content-note/index.tsx

Co-authored-by: Peter Bengtsson <peterbe@mozilla.com>

* Update client/src/document/molecules/localized-content-note/index.tsx

Co-authored-by: Peter Bengtsson <peterbe@mozilla.com>

* prettier

Co-authored-by: Peter Bengtsson <peterbe@mozilla.com>
@gidongkwon
Copy link

I was just wandering across the repos too.

This page was translated from English by the community. Learn more by joining the Korean community on MDN.

could be translated in Korean by

이 페이지는 커뮤니티에서 영어로 번역되었습니다. MDN에서 한국 커뮤니티에 가입하여 자세히 알아보세요.

"Korean" (ko): TBD (@chrisdavidmills can provide this when it's ready)

@chrisdavidmills I hope it helped a little. :)

I think the "커뮤니티에서 영어로 번역되었습니다" part seems bit awkward, because it means "translated to English" isn't it?
Correct full translation would be something like:

이 페이지는 커뮤니티에 의해 영어로부터 번역되었습니다. MDN의 한국 커뮤니티에 가입하여 자세히 알아보세요.

With some more explanation in it, would be:

이 페이지는 커뮤니티가 영어를 한국어로 번역했습니다. MDN의 한국 커뮤니티에 가입하여 자세히 알아보세요.

What do you think? @hochan222

@hochan222
Copy link
Member

hochan222 commented Jun 1, 2021

@gidongkwon Since then, I have corrected it in another PR. If you go to the Korean page, the modified text will appear at the top. https://github.com/mdn/yari/pull/3733/files

"이 페이지는 영어로부터 커뮤니티에 의하여 번역되었습니다. MDN Web Docs에서 한국 커뮤니티에 가입하여 자세히 알아보세요.",

@gidongkwon
Copy link

Looks good. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend general frontend issues p1 We will address this soon and will provide capacity from our team for it in the next few releases.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants