Prominent disclosure when "handling users' Files" #148
Comments
|
Created the PR#150 where the Tomorrow I'll check the necessary changes to implement at runtime the prominent disclosure requested by Google, but it's possible the move may require changes in the way the CHT requires access to the file storage (though thinking it well, it shouldn't, because we are not accessing any JS API to request storage access, it is required when the user clicks in an upload field 🤔 ) So, we have 2 alternatives:
Regardless of the choice, we can still keep the changes from PR#150 and remove the storage permission at all for those flavors, making the Play Store approval process simpler, but we will need to keep in sync what flavors do access to the local storage to avoid the app to crash. In this case we can also add a change using the Android API to check whether the app has the permission in the manifest and avoid the app crashing and letting the user know about the error, despite it shouldn't happen. |
|
Checking in with existing deployments, I asked @derickl:
To which he replied:
@derickl - I'm going to assume it's OK if we remove the feature as needed for this ticket. We can re-introduce the feature as needed at a later date which can then be play store compliant. |
|
OK, here's the latest from @kennsippell when asked by @derickl if the upload feature was OK to remove:
@MaxDiz and @garethbowen - I think you two have been on point in the past about communicating medic-android changes like this |
|
Adding to v3.11 to include as part of the next android release. Based on the roadmap planning discussion, we want to maintain the ability to access local storage to align with x-forms functionality and long-term direction for the product. @mrsarm please follow-up with @craig-landry regarding best pathway forward |
|
Hi @mrsarm . I see that for flavours that had the access storage permission, there is an additional attribute |
|
Version of the app v0.7.3 (not released yet) is going to include the removal of the storage permission for most flavors that are not using the permission (pull/150). The plan for the next major release (v.0.8.0?) is to add the perm again, adding the prominent disclosure requested by the Play Store, so I'll keep this ticket open for follow-up. |
|
Thanks @mrsarm . Since this was not a functional change, QA will do a quick sanity check on the newly created |
Side loading selected APKs, including newly created ones (safaridoctors_kenya, trippleeighty and icm_ph_chc)... from GH releases - 2. Open the app (just the login page as flavoured apks point to production servers for most part)==> All apps tested open without crashing - except ==> Also 'CHAMP', the app for ICM PH, does not have all languages required and no translation for Tagalog on the login page. Obviously this is a server-side issue and I assume @binokaryg is still working with the partner with regard to translations ( and upgrading their instance to latest medic version that has the additional languages and translations)? |
3 . Other features testeda) Private policy translations when the user logs in with a preferred language b) Location access disclosure when the system language is Tagalog c) Reports are saved with or without location data depending on whether the user accepted or not d) MRDT app |
garethbowen
added
Type: Bug
|
Move the ticket to the 4.0.0 board. We disabled the access to files from the app for all the active flavors (#150), so the problem of not being delisted from Google Play is solved, and due this bug #127 we need first to re-implement the file uploader picker #159, that is scheduled for the 4.0.0 release. |
|
More about prominent disclosure process from Android.
@garethbowen should we add the privacy policy as part of the release process for Android apps? I couldn't find it |
|
This is probably the closest thing we've got: https://docs.communityhealthtoolkit.org/core/guides/android/publishing/#new-app-in-the-play-store There are heaps of requirements for listing on Google Play (see this internal guide for how Medic App Services do it) and I don't want to try and duplicate them all in the docs site because it'll quickly get out of date. Fortunately the Play Store walks you through the steps - if you create a new app it has a section on Privacy Policies which you must fill out before your app will show. We could add a sentence or two to the publishing page about following the Play Store steps potentially with a link to an Google resource on how to do it? |
|
This is ready for AT in this PR. The PR includes the following:
See screenshots in the PR's description. |
|
I have been getting some strange behaviour when I press "Launch App". The app goes to Testing with an android 10 phone. Did you want to have a second look @latin-panda ? or ping if you need more logs. 148.mov |
|
Redirecting to app's settings page is okay for the scenario #2. There might be an issue in Android 10, I'm going to see what's the problem later today. |
|
I found the issue @latin-panda . Last year the storage permission was removed and Mariano created a new flavour ( storage.mov |
|
Good to merge @latin-panda '. New ticket created to remove the flavour. |
Ticket: #148 This commit: - Adds a prominent disclosure for when requesting storage permission - Updates location prominent disclosure to use intent's callback contracts. - Handle "never ask again" or when permission is denied for second time or when the permission is denied from the App's Settings page, at this point we can't request the grant automatically so the user is redirected to the app's settings to manually grant the permission.
Ticket: medic#148 This commit: - Adds a prominent disclosure for when requesting storage permission - Updates location prominent disclosure to use intent's callback contracts. - Handle "never ask again" or when permission is denied for second time or when the permission is denied from the App's Settings page, at this point we can't request the grant automatically so the user is redirected to the app's settings to manually grant the permission.
Follow-up after #136
Apps are getting denied from the app store because we are requesting
READ_EXTERNAL_STORAGEwithout a prominent alert asking for access. See screenshot for details form google.The text was updated successfully, but these errors were encountered: