Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add sonar configuration #352

Merged
merged 1 commit into from
Mar 22, 2024
Merged

chore: Add sonar configuration #352

merged 1 commit into from
Mar 22, 2024

Conversation

jkuester
Copy link
Contributor

Adding sonar configuration as part of the process for enabling Sonar on a new repo.

Copy link
Collaborator

@mrjones-plip mrjones-plip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥼 !!

spot checked docs and compared to CHT Core's version - looks good!

not at all blocking merge, but do we need to specify java version like we specify python version?

@jkuester
Copy link
Contributor Author

I do not think we need to specify the Java version since Sonar should be about to load it from the build.gradle config. At least I hope so, since I do not really want another place to have to update whenever we bump the Java version...

@jkuester jkuester merged commit 889fd84 into master Mar 22, 2024
6 checks passed
@jkuester jkuester deleted the sonar branch March 22, 2024 21:33
sugat009 pushed a commit that referenced this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants