Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security fixes in SDP code #2214

Merged
merged 4 commits into from
Jun 9, 2020
Merged

Security fixes in SDP code #2214

merged 4 commits into from
Jun 9, 2020

Conversation

lminiero
Copy link
Member

@lminiero lminiero commented Jun 9, 2020

We've been notified about a series of security issues related to SDP (see relevant CVE IDs below, vulnerabilities discovered by Mikhail Evdokimov at Digital Security dsec.ru). Specifically, each commit in this PR solves a different issue that could happen:

  1. a NULL pointer dereference when parsing some SDP attributes (see CVE-2020-13898);
  2. a stack memory leak (and a "regular" one) when pre-parsing an SDP (see CVE-2020-13899);
  3. a different NULL pointer dereference when pre-parsing an SDP (see CVE-2020-13900);
  4. a buffer overflow when merging SDPs (see CVE-2020-13901).

I plan to merge this almost immediately, as I can't replicate the issues anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant