Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replay data channel recordings #2468

Merged
merged 11 commits into from
Dec 7, 2020
Merged

Replay data channel recordings #2468

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
24b5360
Replay data channel recordings
Dec 2, 2020
d36e483
Corrections based on pull request feedback
Dec 3, 2020
aa2a5d2
Now correctly handles data packet header
Dec 3, 2020
3d7b7d6
Removed unnecessary code.
Dec 3, 2020
8b76b17
Removed unnecessary code.
Dec 3, 2020
524fe7a
Minor corrections.
Dec 3, 2020
d83f407
Comment style fix.
Dec 3, 2020
99969b6
get_frames now correctly parses data recording
Dec 3, 2020
d05f09b
First data packet now plays on correct timestamp
Dec 4, 2020
31731a5
Added cleanup code to avoid memory leaks.
Dec 7, 2020
2887690
Minor cosmetic change to match project read usage
Dec 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion html/recordplaytest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ $(document).ready(function() {
recordplay.createAnswer(
{
jsep: jsep,
media: { audioSend: false, videoSend: false }, // We want recvonly audio/video
media: { audioSend: false, videoSend: false, data: true }, // We want recvonly audio/video
success: function(jsep) {
Janus.debug("Got SDP!", jsep);
var body = { request: "start" };
Expand Down Expand Up @@ -314,6 +314,16 @@ $(document).ready(function() {
$('#thevideo').removeClass('hide').show();
}
},
ondataopen: function(data) {
Janus.log("The DataChannel is available!");
$('#videobox').append(
'<input class="form-control" type="text" id="datarecv" disabled></input>'
);
},
ondata: function(data) {
Janus.debug("We got data from the DataChannel!", data);
$('#datarecv').val(data);
},
oncleanup: function() {
Janus.log(" ::: Got a cleanup notification :::");
// FIXME Reset status
Expand Down
Loading