Allow Lua and Duktape plugins to relay extensions when relaying RTP packets #3162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we merged #1884, the Lua and Duktape plugins had basically no RTP extensions support, except for those originated by the core (e.g., mid). In fact, since #1884 required the plugins to explicitly use the
.extensionsproperty to carry on specific extensions, and Lua/Duktape didn't use it (simply resetting the struct), this resulted in extension properties passed by media senders to be stripped by the core when relaying packets to receivers. This patch addresses this shortcoming, and ensures we now copy the struct along properly. I've tested this briefly with theaudio-levelextension in both plugins, and it looks like it's working as expected.Planning to merge soon, so if you have feedback please do say so.