Don't create IPv6 sockets if IPv6 is completely disabled (see #3159) #3179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explained in #3159, the change we made there to switch to
getaddrinfocaused the involved plugins to break on machines where IPv6 is entirely disabled (and not just not present). See this post on Discourse for context. This PR applies the same fix we added in #2916 for forwarders to the sockets we changed in SIP/NoSIP/AudioBridge.Please test and provide feedback, as I have no way to test this myself (I don't have IPv6 on my machine but it's not disabled).