rtcp: fix FIR parsing #3528
Merged
rtcp: fix FIR parsing #3528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adding a new toggle is fine, but I wouldn't remove the check we had, since that was definitely working with other implementations we tested FIR with back then (which is arguable ages ago, before we definitely moved to PLI). |
FIR RTCP packets sent by GStreamer were not handled by Janus but PLI ones are. According to https://www.rfc-editor.org/rfc/rfc5104#section-4.3.1 FIR are PSFB packets with FMT=4 so I'm now parsing them as we do with PLI.
|
I updated the patch to keep the existing implementation as well then. |
|
LGTM 👍 |
|
Thanks, merging then! I'll backport that to |
lminiero
pushed a commit
that referenced
this pull request
Mar 15, 2025
FIR RTCP packets sent by GStreamer were not handled by Janus but PLI ones are. According to https://www.rfc-editor.org/rfc/rfc5104#section-4.3.1 FIR are PSFB packets with FMT=4 so I'm now parsing them as we do with PLI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIR RTCP packets sent by GStreamer were not handled by Janus but PLI ones are.
According to https://www.rfc-editor.org/rfc/rfc5104#section-4.3.1 FIR are PSFB packets with FMT=4 so I'm now parsing them as we do with PLI.