This repository was archived by the owner on Nov 27, 2023. It is now read-only.
Handle redeclaration errors from the broker #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RabbitMQ will return an error, whenever clients try to redeclare an existing resource with different parameters, for example: * an existing exchange with different type Currently, terminate callbacks are not matching this specific error message, so publishers and consumers will crash with: `FunctionClauseError`. This makes it hard to understand what exactly has happened: https://github.com/meltwater/gen_rmq/issues/142 With these changes: * terminate callbacks will be called * corresponding error will be logged
|
nice, tks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RabbitMQ will return an error, whenever clients try to redeclare an
existing resource with different parameters, for example:
Currently, terminate callbacks are not matching this specific error message,
so publishers and consumers will crash with:
FunctionClauseError.This makes it hard to understand what exactly has happened:
https://github.com/meltwater/gen_rmq/issues/142
With these changes:
Description
Checklist