Mermaid 9.2.0 triggers webpack import warning

[matchaxnb]

Description

When I import Mermaid in my Webpack project (based on backstage with plugin techdocs-addon-mermaid, 9.2.0 triggers a warning.

Compiled with problems:X

WARNING in ../../node_modules/mermaid/dist/mermaid.core.mjs 27645:52-67

Critical dependency: the request of a dependency is an expression


WARNING in ../../node_modules/mermaid/dist/mermaid.core.mjs 27659:52-63

Critical dependency: the request of a dependency is an expression

After investigating, it seems this is due to uses of await import(url) and await import(diagram), url and diagram being dynamic. Webpack sees that as bad.

I would recommend

Steps to reproduce

1. Use Mermaid 9.2.0 in a project that uses Webpack 5.7.0

2. Build in development mode

3. See the issue
   or

4. Install Backstage with Yarn 3 and up-to-date packages

5. Install plug-in https://github.com/johanneswuerbach/backstage-plugin-techdocs-addon-mermaid but set MermaidJS version to 9.2.0

6. run yarn dev

7. see the error in the web UI.

Screenshots

No response

Code Sample

No response

Setup

Desktop

• OS and Version: ArchLinux x86_64
• Browser and Version: Chrome 106
• Built with NodeJS 16, Webpack 5.7.0, Yarn 3.

Additional Context

No response

[Just-Sieb]

I was having the same problem with our Backstage instance and trying to add that plugin in. I resolved the issue for now by setting the resolution in the top level package.json to lock it to Mermaid v9.1.1. It seems that this change

{
  ...
  "resolutions": {
    "mermaid": "9.1.1"
  },
  ...
}

I am guessing PR #3591 broke Webpack being able to import Mermaid

[Just-Sieb]

This is also probably a duplicate of #3754

[boldt]

FYI: Even with 9.2.1, I still see Critical dependency: the request of a dependency is an expression.

[sidharthv96]

But the fix for that is in #3774, which hasn't been merged yet due to pnpm issue.

[boldt]

Thanks, but the release notes say, that this MR ist fixed:

fix #3757 : Remove dynamic imports for lazy load causing issues for webpack

[sidharthv96]

Must've been a mistake, Struck it off.

[sidharthv96]

Can you please test 9.2.2-rc.2

[boldt]

9.2.2 works for me.