Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in one diagram causes rest to not render #4003

Closed
sidharthv96 opened this issue Jan 17, 2023 · 1 comment · Fixed by #4004
Closed

Error in one diagram causes rest to not render #4003

sidharthv96 opened this issue Jan 17, 2023 · 1 comment · Fixed by #4004
Labels
Good first issue! Status: Approved Is ready to be worked on Status: Awaiting PR Type: Bug / Error Something isn't working or is incorrect

Comments

@sidharthv96
Copy link
Member

Description

Found while testing 57-elk: handle nested subgraphs with outgoing links 4 failure.

Even if one diagram fails, the rest of them should render properly.

Steps to reproduce

Screenshots

image

Code Sample

No response

Setup

Desktop

  • OS and Version: [Windows, Linux, Mac, ...]
  • Browser and Version: [Chrome, Edge, Firefox]

Smartphone

  • Device: [Samsung, iPhone, ...]
  • OS and Version: [Android, iOS, ...]
  • Browser and Version: [Chrome, Safari, ...]

Additional Context

No response

@sidharthv96 sidharthv96 added Type: Bug / Error Something isn't working or is incorrect Status: Triage Needs to be verified, categorized, etc Status: Approved Is ready to be worked on Good first issue! Status: Awaiting PR and removed Status: Triage Needs to be verified, categorized, etc labels Jan 17, 2023
@sidharthv96
Copy link
Member Author

So this is what's happening.

https://www.typescriptlang.org/play?#code/MYewdgzgLgBAlmMBTATjAvDAFASgwPhgG8AoGcmFJKAVxTBmQHcYAFFEAWzgiSyoggANgDckBYmQrT2XHkgB0A4WNwKoACyRgsuCaWmGKcAGZYAjHk0cWzGAFEUHFFgBEAeRAAHCK5wBuKSNpZVE+VwATcCQ-QOCYAF8cIMTkhJISUEhYEBooVAwYAEMIAE8wYGw8dEIDCigUUsl4oqYiuFgEZBcAlISYYCKoYA1sVGccOqMswSFFIRAAcyxxkBRk6XT0khEQOAiYXPye-yA

The error is thrown from here.

elk.layout(graph).then(function (g) {
drawNodes(0, 0, g.children, svg, subGraphsEl, diagObj, 0);
g.edges.map((edge, id) => {
insertEdge(edgesEl, edge, edge.edgeData, diagObj, parentLookupDb);
});
setupGraphViewbox({}, svg, conf.diagramPadding, conf.useMaxWidth);
resolve();
});

sidharthv96 added a commit that referenced this issue Jan 17, 2023
Add eslint rules to check for unhandled promises
Fix all existing unhandled promise issues
knsv added a commit that referenced this issue Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good first issue! Status: Approved Is ready to be worked on Status: Awaiting PR Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant