Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken internal links in README #2145

Merged
merged 1 commit into from
Jul 7, 2021
Merged

Fix broken internal links in README #2145

merged 1 commit into from
Jul 7, 2021

Conversation

carbeer
Copy link
Contributor

@carbeer carbeer commented Jun 23, 2021

📑 Summary

Brief description about the content of your PR.

Resolves #

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added unit/e2e tests (if appropriate)
  • 🔖 targeted develop branch

@knsv
Copy link
Collaborator

knsv commented Jun 25, 2021

For me these liks already work like for instance:
https://mermaid-js.github.io/mermaid/#/flowchart?id=flowcharts-basic-syntax

In what context are they broken?

@carbeer
Copy link
Contributor Author

carbeer commented Jun 25, 2021

The issue arises when using the README on Github directly.

@knsv
Copy link
Collaborator

knsv commented Jul 7, 2021

@carbeer Thanks Carolin! We really want it to work on Github as well!

@knsv knsv merged commit eaec4c9 into mermaid-js:develop Jul 7, 2021
@carbeer carbeer deleted the patch-1 branch July 7, 2021 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants