Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove entity-decode dependency #2175

Merged
merged 3 commits into from
Jul 7, 2021

Conversation

sidharthv96
Copy link
Member

@sidharthv96 sidharthv96 commented Jul 6, 2021

📑 Summary

Removed the dependency on entity-decode and added the functionality into utils.

Resolves #1603

📏 Design Decisions

It was a 3 Year unmaintained dependency without any complex logic.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added unit/e2e tests (if appropriate)
  • 🔖 targeted develop branch

…ity-decode

* 'develop' of github.com:sidharthv96/mermaid:
  Update flowchart.md
  Added new theme user journey diagram specific theme variables
  fix typo
  2122 Blöockling javascript urls
  fix: Assign proper namespaces to foreignObject children
  Small positoining fix for parallell processes and nested composite states
  Version update in the docs
  Updated version in package.json and recompile
  Lint fix
  fix typo
  Fix for styling
  Fox fr keeping the label background in state diagrams
  Removed  unused dependency "he"
  Ensuring "minify" is only listed as a dev dependency
  Update n00b-syntaxReference.md
  Update _sidebar.md
  [docs] Update default log level value
@sidharthv96 sidharthv96 requested a review from knsv July 6, 2021 20:38
@sidharthv96 sidharthv96 self-assigned this Jul 6, 2021
Copy link
Collaborator

@knsv knsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good! That fix was long overdue!

@knsv knsv merged commit fa07abd into mermaid-js:develop Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SyntaxError: Unexpected token 'export'
2 participants