fix: rotate class id when branch more than 8 #3150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i not sure why static analysis is failing. can someone advise? |
Closed
sidharthv96
reviewed
Jun 21, 2022
sidharthv96
reviewed
Jun 21, 2022
|
@sidharthv96 changed as per comment. |
|
@faisalarbain please add a snapshot test in |
faisalarbain
force-pushed
the
bug/3149_gitgraph_more_than_8_branches
branch
from
cfe12f7 to
1868ae1
Compare
|
@sidharthv96 added and rebased |
sidharthv96
approved these changes
Jun 29, 2022
Yash-Singh1
changed the title
Yash-Singh1
approved these changes
Jun 29, 2022
|
Is there any roadmap or eta on when this one can be merged? |
faisalarbain
force-pushed
the
bug/3149_gitgraph_more_than_8_branches
branch
from
1868ae1 to
9ee43c0
Compare
|
rebase to resolve conflict. but some test were break not related to the changes |
|
Thanks @faisalarbain! Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Summary
Arrow are not visible when total branches more than 8. The issue also reported in ticket below:
Resolves #3149
📏 Design Decisions
The fix is following current implementation for branch tag's color under
drawBranchesmethods where it adjustIndexForTheme by deducting with 8 (magic number)I extract the magic number into const to make it easy to refactor/change the value in future.
Screenshot
This is using snippet provided in #3149