Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💄 section width now covers all tasks - Timeline #4126

Merged
merged 6 commits into from
Feb 28, 2023

Conversation

sidharthv96
Copy link
Member

📑 Summary

Inspired from #4074

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added unit/e2e tests (if appropriate)
  • 📓 have added documentation (if appropriate)
  • 🔖 targeted develop branch

@sidharthv96 sidharthv96 added this to the 10.0.1 milestone Feb 24, 2023
er,
gantt,
info,
pie,
requirement,
sequence,
flowchartElk,
// TODO @knsv: Should v2 come before flowchart?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine. The legacy detector only triggers on graph and if the default renderer has not been configured to be dagre-wrapper this one, (flowchart), should kick in.

Copy link
Collaborator

@knsv knsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ready to go!

@knsv knsv merged commit 0bed5d7 into develop Feb 28, 2023
@Yokozuna59 Yokozuna59 deleted the sidv/timelineSectionWidth branch August 11, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants